Skip to content

Fixes #2289. View.Clear method is clearing beyond its parent bounds. - #2290

Merged
tig merged 2 commits into
tui-cs:developfrom
BDisp:view-clear-fix_2289
Jan 16, 2023
Merged

Fixes #2289. View.Clear method is clearing beyond its parent bounds.#2290
tig merged 2 commits into
tui-cs:developfrom
BDisp:view-clear-fix_2289

Conversation

@BDisp

@BDisp BDisp commented Jan 15, 2023

Copy link
Copy Markdown
Collaborator

Fixes #2289 - Clear method now check its parent bounds first.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@tig
tig merged commit 7605e2b into tui-cs:develop Jan 16, 2023
@BDisp
BDisp deleted the view-clear-fix_2289 branch January 16, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View.Clear method is clearing beyond its parent bounds.

2 participants